On 12/23/2016 15:19, Christoph Hellwig wrote: > On Fri, Dec 23, 2016 at 09:32:15AM +0800, Kinglong Mee wrote: >> Commit fae5096ad217 "nfsd: assume writeable exportabled filesystems have f_sync" >> have remove the setting of stable. > > Btw, that commit really should check for fsync support at export > time then, never underestimate how broken file systems could be. > We can check it in check_export() when exporting filesystem, but, what can we do for the unsupported fsync filesystem? Just a warning message? or deny the exporting? I'd prefer the first one. thanks, Kinglong Mee -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html