Re: [PATCH resend] NFSv4.1: nfs4_fl_prepare_ds must be careful about reporting success.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> On Dec 18, 2016, at 19:19, NeilBrown <neilb@xxxxxxxx> wrote:
> 
> 
> Various places assume that if nfs4_fl_prepare_ds() turns a non-NULL 'ds',
> then ds->ds_clp will also be non-NULL.
> 
> This is not necessasrily true in the case when the process received a fatal signal
> while nfs4_pnfs_ds_connect is waiting in nfs4_wait_ds_connect().
> In that case ->ds_clp may not be set, and the devid may not recently have been marked
> unavailable.
> 
> So add a test for ds_clp == NULL and return NULL in that case.
> 
> Fixes: c23266d532b4 ("NFS4.1 Fix data server connection race")
> Signed-off-by: NeilBrown <neilb@xxxxxxxx>
> Acked-by: Olga Kornievskaia <aglo@xxxxxxxxx>
> Acked-by: Adamson, Andy <William.Adamson@xxxxxxxxxx>
> ---
> 
> Hi Trond,
> I just noticed that this wasn't in your 4.10 pull request.  So I've
> added Acked-bys from Andy and Olga and am resending.
> 

Sorry for having missed their Acked-bys earlier… I’ll send this together with the other 10 patches tomorrow.

Cheers
  Trond

��.n��������+%������w��{.n�����{��w���jg��������ݢj����G�������j:+v���w�m������w�������h�����٥




[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux