On Tue, Nov 29, 2016 at 03:59:29PM -0500, Anna Schumaker wrote: > Sorry for the delay! I've been busy looking at other things and > forgot to update the copy_file_range() stuff :( While you're at it, please make a test to check the return value for invalid inputs. I'd prefer we avoid repeating what happened with the vfs dedupe ioctl. --D > > On 11/29/2016 03:47 PM, J. Bruce Fields wrote: > > On Fri, Nov 25, 2016 at 12:05:10AM -0800, Christoph Hellwig wrote: > >> On Wed, Oct 26, 2016 at 01:26:38AM -0700, Christoph Hellwig wrote: > >>> On Wed, Sep 07, 2016 at 03:56:15PM -0400, Anna Schumaker wrote: > >>>> These tests exercise the copy_file_range() system call, and check copying > >>>> data to both a new file and overwriting data inside an existing file. I use > >>>> the xfs_io "copy_range" command for the actual copies, so running these > >>>> tests requires an up-to-date version of xfsprogs. > >>> > >>> Hi Anna, > >>> > >>> what's the status of these tests? Did you get a chance to look > >>> into xfs_io copyfile support? > > xfs_io has support for copying now, so I'll make sure that the tests > use that correctly. I promise to send out an update this week, once I > check that everything still works! > > Thanks for the reminders, > Anna > > >> > >> Another month, another ping - it would be really sad to not have any > >> real testing for copy_file_range. > > > > Agreed, Anna, are you still planning on doing this? > > > > --b. > > > >> I've been holding a pending change > >> for it back for month now because I want to verify it more than cursory, > >> but I guess I'll just have to send it anyway. > >> -- > >> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in > >> the body of a message to majordomo@xxxxxxxxxxxxxxx > >> More majordomo info at http://vger.kernel.org/majordomo-info.html > -- > To unsubscribe from this list: send the line "unsubscribe fstests" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
