Re: [PATCH pynfs 00/12] Flex File support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Nov 28, 2016 at 11:33:21AM -0500, J. Bruce Fields wrote:
> On Sat, Nov 26, 2016 at 10:26:29PM -0800, Tom Haynes wrote:
> > I wanted to add client support for the flex file layout.
> > 
> > Note, I did not add pynfs as a flag because I didn't want to
> > mess up with any existing uses of it.
> > 
> > The other major change here is in closing all opened
> > files and destroying all clientids. With all the tests
> > which run against my server, there are no longer any
> > open files. There are however 11 clientids remaining.
> > 
> > I will track those down.
> > 
> > fwiw - these are in my staging branch at git://linux-nfs.org/~loghyr/pynfs.git
> 
> Thanks!  I'll try these and take a look.

It breaks all the 4.0 tests:

	ACC3     st_access.testNoFh : FAILURE
	           AttributeError: 'Environment' object has no attribute
		              'clean_clients'

The problem is that nfs4.1/testmod.py is used by 4.0 as well, but
there's not a 4.0 version of clean_clients.... Simplest I guess is to do
as with clean_sessions and define a dummy method.

--b.

diff --git a/nfs4.0/servertests/environment.py b/nfs4.0/servertests/environment.py
index 6fe083a..221c3ed 100644
--- a/nfs4.0/servertests/environment.py
+++ b/nfs4.0/servertests/environment.py
@@ -229,6 +229,9 @@ class Environment(testmod.Environment):
     def clean_sessions(self):
         return
 
+    def clean_clients(self):
+       return
+
 #########################################
 debug_fail = False
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux