On Tue, 15 Nov 2016, Trond Myklebust wrote:
>
> > On Nov 15, 2016, at 15:59, Scott Mayhew <smayhew@xxxxxxxxxx> wrote:
> >
> > The nfs_server->mountd_protocol field doesn't get set when a v3 submount
> > is created, causing /proc/mounts to show 'mountproto=' without a netid.
> > This in turn causes umount.nfs to emit the error message "Failed to find
> > '' protocol" if you manually unmount the submount.
> >
> > Signed-off-by: Scott Mayhew <smayhew@xxxxxxxxxx>
> > ---
> > fs/nfs/super.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/fs/nfs/super.c b/fs/nfs/super.c
> > index 001796b..b60946d 100644
> > --- a/fs/nfs/super.c
> > +++ b/fs/nfs/super.c
> > @@ -532,7 +532,8 @@ static void nfs_show_mountd_netid(struct seq_file *m, struct nfs_server *nfss,
> > {
> > struct sockaddr *sap = (struct sockaddr *) &nfss->mountd_address;
> >
> > - seq_printf(m, ",mountproto=");
> > + if (nfss->mountd_protocol || showdefaults)
> > + seq_printf(m, ",mountproto=");
> > switch (sap->sa_family) {
> > case AF_INET:
> > switch (nfss->mountd_protocol) {
>
> Does it make sense to call nfs_show_mountd_options() at all for the case of a v3 submount?
>
Probably not, but I don't see a way to positively identify that it's a
submount if all you have is the nfs_server struct (I don't see a way to
backtrack to the mount struct). Or are you suggesting to just check one
of the mountd-related fields (say mountd_addrlen) before calling
nfs_show_mount_options() and skip it altogether if appropriate?
-Scott
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
