Re: [PATCH] NFSv41: fix NULL dereference in nfs40_setup_sequence

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> On 31 Oct 2016, at 18:46, Trond Myklebust <trondmy@xxxxxxxxxxxxxxx> wrote:
> 
> 
>> On Oct 30, 2016, at 21:18, Vitaliy Gusev <gusev.vitaliy@xxxxxxxxx> wrote:
>> 
>> Hi.
>> 
>> During some tests I’ve seen nfs-client crashes. It was just reading file via NFSv4.1 protocol. 
>> 
>> The panic message is below,  fixing patch is attached.
> 
> Why does this need to be fixed on the client? It looks like a server bug… In any case, the fix you propose is going to leave the client with broken open state.

Do you like to get crash every time a remote side sends improper datas? I believe not.

I proposed just ignore the flag OPEN4_RESULT_CONFIRM  for nfs4.1+ clients.
RFC5661 has description that allows a client to do that:

   o  OPEN4_RESULT_CONFIRM is deprecated and MUST NOT be returned by an
       NFSv4.1 server.

———

Thanks,
Vitaliy Gusev

--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux