On Thu, Oct 20, 2016 at 03:22:00AM -0700, Christoph Hellwig wrote: > On Tue, Oct 18, 2016 at 05:37:55PM -0400, J. Bruce Fields wrote: > > The NFS code is using sg_set_buf to turn a bit of stack menory into a > > scatterlist it can pass to the crypto code. That started BUG()ing as of > > ac4e97abce9b "scatterlist: sg_set_buf() argument must be in linear > > mapping". > > > > Is that BUG() being overly strict, or is this something we should never > > have been doing in the first place? > > In general we use scatterlists to pass dma addresses to hardware, so > yes, they should not point to the stack. The crypto code isn't actually doing that though, is it? (Or is there a chance it could be passing the data to separate crypto hardware? Do people do that these days?) --b. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html