On Fri, Oct 14 2016, Trond Myklebust wrote:
>> On Oct 13, 2016, at 03:18, NeilBrown <neilb@xxxxxxxx> wrote:
>>
>>
>> Suppose I open/create a file over pNFS and am given a WRITE delegation.
>> I then chmod the file (as rsync is wont to do) so the delegation is
>> immediately returned.
>> I then proceed to write, which triggers a LAYOUT_GET request. The
>> stateid for that request it taken from state->stateid, which is still
>> the delegation stateid. Naturally it gets NFS4ERR_BAD_STATEID.
>
> Umm… Why isn’t the client recovering open stateids as part of the delegation return? That would appear to be the root cause problem here.
Ahh.. that's where it happens. Of course. Thanks.
I was thinking that where would be no opens to recover because the
delegation wasn't used to complete any other opens. But there is more
to the recovery than that.
>
> Is this the latest upstream kernel?
No, it is 3.12 based. I now see that I am just missing
Commit: 5e99b532bb95 ("nfs4: reset states to use open_stateid when returning delegation voluntarily")
Thanks!
NeilBrown
Attachment:
signature.asc
Description: PGP signature
