> On Sep 16, 2016, at 17:21, Oleg Drokin <green@xxxxxxxxxxxxxx> wrote: > > > On Sep 16, 2016, at 5:15 PM, Oleg Drokin wrote: > >> >> On Sep 16, 2016, at 11:36 AM, Trond Myklebust wrote: >> >>> On Fri, 2016-09-16 at 00:38 -0400, Oleg Drokin wrote: >>>> On Sep 15, 2016, at 12:45 PM, Trond Myklebust wrote: >>>> >>>>> >>>>> According to RFC5661, if any of the SEQUENCE status bits >>>>> SEQ4_STATUS_EXPIRED_ALL_STATE_REVOKED, >>>>> SEQ4_STATUS_EXPIRED_SOME_STATE_REVOKED, >>>>> SEQ4_STATUS_ADMIN_STATE_REVOKED, >>>>> or SEQ4_STATUS_RECALLABLE_STATE_REVOKED are set, then we need to >>>>> use >>>>> TEST_STATEID to figure out which stateids have been revoked, so we >>>>> can acknowledge the loss of state using FREE_STATEID. >>>>> >>>>> While we already do this for open and lock state, we have not been >>>>> doing >>>>> so for all the delegations. >>>>> >>>>> v2: nfs_v4_2_minor_ops needs to set .test_and_free_expired too >>>>> v3: Now with added lock revoke fixes and close/delegreturn/locku >>>>> fixes >>>>> v4: Close a bunch of corner cases >>>> >>>> This one seems to be looping on the client in a way very similar >>>> to the first failure in that it's the serverip-named process that's >>>> using the cpu, but the debug log is very similar to the second >>>> failure >>>> in test stateid, except this time it's not "success 0", but "success >>>> -10025": >>>> >>> Ah... I think I see what the issue is... Does the following help? >> >> Well, it changed the output back to what I had with the first patch set, I think: >> I.e. now it's nfsid test succeded, 0, and the process using the cpu is again >> a userspace one: > > Ah, I did not realize you probably meant not to apply this on top of the previous > batch, but replace patch #14 with this one. > So I am trying it now. No, not at all. What you did was entirely correct. I’ve inserted it into position 14 in the ‘v5’ patch series because that is where it belongs in order to prevent bisection issues, but it should work identically on top of the existing v4... Thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
