Re: [PATCH] sunrpc: include gid in the rpc_cred_cache hash

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Frank,

[auto build test WARNING on nfs/linux-next]
[also build test WARNING on v4.8-rc6 next-20160916]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
[Suggest to use git(>=2.9.0) format-patch --base=<commit> (or --base=auto for convenience) to record what (public, well-known) commit your patch series was built on]
[Check https://git-scm.com/docs/git-format-patch for more information]

url:    https://github.com/0day-ci/linux/commits/Frank-Sorenson/sunrpc-include-gid-in-the-rpc_cred_cache-hash/20160917-042716
base:   git://git.linux-nfs.org/projects/trondmy/linux-nfs.git linux-next
config: microblaze-mmu_defconfig (attached as .config)
compiler: microblaze-linux-gcc (GCC) 6.2.0
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=microblaze 

All warnings (new ones prefixed by >>):

   net/sunrpc/auth.c: In function 'rpcauth_hash_acred':
>> net/sunrpc/auth.c:545:41: warning: left shift count >= width of type [-Wshift-count-overflow]
      (from_kuid(&init_user_ns, acred->uid) << (sizeof(gid_t) * 8)),
                                            ^~

vim +545 net/sunrpc/auth.c

   529		unsigned long diff;
   530		unsigned int nr_to_scan;
   531	
   532		if (number_cred_unused <= auth_max_cred_cachesize)
   533			return;
   534		diff = number_cred_unused - auth_max_cred_cachesize;
   535		nr_to_scan = 100;
   536		if (diff < nr_to_scan)
   537			nr_to_scan = diff;
   538		rpcauth_cache_do_shrink(nr_to_scan);
   539	}
   540	
   541	static unsigned int
   542	rpcauth_hash_acred(struct auth_cred *acred, unsigned int hashbits)
   543	{
   544		return hash_64(from_kgid(&init_user_ns, acred->gid) |
 > 545			(from_kuid(&init_user_ns, acred->uid) << (sizeof(gid_t) * 8)),
   546			hashbits);
   547	}
   548	
   549	/*
   550	 * Look up a process' credentials in the authentication cache
   551	 */
   552	struct rpc_cred *
   553	rpcauth_lookup_credcache(struct rpc_auth *auth, struct auth_cred * acred,

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: Binary data


[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux