Steve, Chuck, Mike, All, On 2016-08-17 10:26 -0400, Steve Dickson spake thusly: > On 08/15/2016 04:49 PM, Yann E. MORIN wrote: > > The __P() macro is a legacy compatibility macro aimed making pre-ANSI > > (i.e. K&R) compilers that do not support function prototypes happy, > > while still allowing such prototypes for ANSI-compliant compilers. > > > > Since virtually all compilers have been ANSI-compliant for a few decades > > now, use of __P() is totally useless. > > > > Furthermore, __P() is defined in the non-standard sys/cdefs.h header. > > This header is present in glibc and uClibc, and both have it included > > from many of their headers. So, sys/cdefs.h is automagically included in > > most cases and its macros are available. > > > > However, the musl C library does not provide this sys/cdefs.h header. > > Thus, the build breaks on musl. > > > > For all the above reasons, get rid of __P() wherever it is used; just > > always declare real function prototypes. > > > > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@xxxxxxx> > > Cc: Chuck Lever <chuck.lever@xxxxxxxxxx> > > Cc: Steve Dickson <SteveD@xxxxxxxxxx> > > Cc: Mike Frysinger <vapier@xxxxxxxxxx> > Committed... Thanks all for your reviews and suggestions! :-) Regards, Yann E. MORIN. -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
