On Thu, 2016-08-11 at 18:59 +0200, hch wrote: > On Thu, Aug 11, 2016 at 12:33:47PM -0400, Jeff Layton wrote: > > > > On Thu, 2016-08-11 at 18:25 +0200, hch wrote: > > > > > > Yeah, for file-like layouts there should be a flag in > > > struct nfsd4_layout_ops to disable recalls. > > > > I don't think disabling recalls would be enough, would it? XFS > > still > > wants to break_layout and won't proceed until the layout list is > > empty, > > AFAICT. We need some way to indicate to the lower filesystem not to > > call break_layout in this case. > > XFS only cares about block-like layours where the client has direct > access to the file blocks. I'd need to look how to propagate the > flag into break_layout, but in principle we don't need to do any > recalls on truncate every for file and flexfile layouts. > Hmm...if we aren't ever going to recall files and flexfiles layouts, then do we even need to set a FL_LAYOUT lease for them at all? I think I'll try hacking something up that takes that approach and see if that might be a reasonable fix. -- Jeff Layton <jlayton@xxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
