On Wed, Aug 10, 2016 at 02:46:27PM -0400, Josef Bacik wrote: > On 08/10/2016 02:25 PM, Linus Torvalds wrote: > > On Wed, Aug 10, 2016 at 11:22 AM, Josef Bacik <jbacik@xxxxxx> wrote: > > > On 08/10/2016 02:06 PM, Linus Torvalds wrote: > > > > > > > > More information in the original email on lkml. > > > > > > I'm not subscribed to lkml and for some reason I can't find the original > > > email in any of the lkml/linux-nfs archives. Could you forward more of the > > > details? > > > > Done. > > > > So my naive fix would be something like this > > > From: Josef Bacik <jbacik@xxxxxx> > Date: Wed, 10 Aug 2016 14:43:08 -0400 > Subject: [PATCH] nfsd: fix dentry refcounting problem > > b44061d0b9 introduced a dentry ref counting bug, previously we were grabbing one > ref to dchild in nfsd_create(), but with the creation of nfsd_create_locked() we > have a ref for dchild from the lookup in nfsd_create(), and then another ref in > nfsd_create_locked(). The ref from the lookup in nfsd_create() is never dropped > and results in dentries still in use at unmount. > > Signed-off-by: Josef Bacik <jbacik@xxxxxx> [sorry, had been off-line since yesterday] Patch looks sane; feel free to slap Acked-by: Al Viro <viro@xxxxxxxxxxxxxxxxxx> on it. I think it should go through nfsd tree. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
