On Fri, Jul 22, 2016 at 01:48:52PM -0400, J. Bruce Fields wrote: > From: "J. Bruce Fields" <bfields@xxxxxxxxxx> > > I'm not sure why this was added. It doesn't seem necessary, and no > other caller does this. lookup_one_len() will explode if you call it for non-directory (== !d_can_lookup(), i.e. something without ->lookup()). So unless the callers do guarantee that check being true, it *is* needed. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html