> On Jun 22, 2016, at 14:51, Anna Schumaker <Anna.Schumaker@xxxxxxxxxx> wrote:
>
> On 06/22/2016 02:08 PM, Anna Schumaker wrote:
>> On 06/22/2016 02:06 PM, Trond Myklebust wrote:
>>>
>>>> On Jun 22, 2016, at 13:58, Anna Schumaker <Anna.Schumaker@xxxxxxxxxx> wrote:
>>>>
>>>> Hi Trond,
>>>>
>>>> On 06/21/2016 05:34 PM, Trond Myklebust wrote:
>>>>> Now that we can serialise O_DIRECT and write/truncate using the
>>>>> inode->i_rwsem, we no longer need inode->i_dio_count.
>>>>
>>>> I'm seeing cthon basic tests fail on all NFS versions after applying this patch:
>>>>
>>>> ./test5: read and write
>>>> ./test5: (/nfs/basic) 'bigfile' has size 8192, should be 1048576
>>>> basic tests failed
>>>>
>>>
>>> ???? Connectathon doesn’t use O_DIRECT. Are you sure it is this patch?
>>>
>>
>> Pretty sure. Cthon worked for me at patch #10, but it failed after adding this one.
>
> I retried the tests, and it's actually patch #10 where I start having problems. Sorry for the confusion!
>
That makes more sense, and I think I’ve found the issues. There were 2:
1) The update of iocb->ki_pos was broken.
2) generic_write_checks() needs to run after the file size revalidation
Cheers
Trond��.n��������+%������w��{.n�����{��w��� jg��� �����ݢj����G���� ���j:+v���w�m������w�������h�����٥
