On Wed, Jun 15, 2016 at 02:47:55PM +0000, Trond Myklebust wrote: > >But we need something to lock out new callers of inode_dio_end > >when calling inode_dio_wait. Then again the current code already > >fails to to do that.. > > We could do that by setting the I/O mode to buffered; that still allows > parallelism for the buffered I/O case. I wouldn???t normally expect > applications that use O_DIRECT on NFS to call fsync(), since we always enforce O_DIRECT|O_SYNC semantics. Maybe not applications specificly written for NFS. But if you're using for example qemu on O_DIRECT without O_SYNC and lots of fdatasync calls will be the default behavior. Anyway, as per the other thread we might be able to get rid of the inode_dio_wait call entirely. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
