Re: [PATCH RESEND 03/10] <linux/sunrpc/svcauth.h>: Define hash_str() in terms of hash_string()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



J. Bruce Fields wrote:
> Hm.  Are there some missing includes, maybe?:
> 
> In file included from include/linux/hashtable.h:12:0,
>                  from fs/btrfs/props.c:19:
> include/linux/hash.h: In function `hash_64_genericâ':
>  include/linux/hash.h:76:3: error: implicit declaration of function `BUILD_BUG_ON' [-Werror=implicit-function-declaration]
>    BUILD_BUG_ON(bits > 32 || bits == 0);
>    ^

Ooh, excellent catch!  That's a paper-bag mistake.  Thank you for
saving me from Linus's wrath.

(My lame explanation: "make allyesconfig" is annoyingly slow, and that
error was an afterthought I added after the "real work" parts.  Do you
think that check should even be in there?)

#include <linux/bug.h> and try again, or re-pull...

Oh, bugger, that revealed something else that scrolled past
in previous builds.  I'll push when I've fixed this one, too..

drivers/base/power/trace.c defines its own static hash_string()
function *and* includes <limux/dcache.h>, leading to conflicting
declarations.  Which one to rename...?


Anyway, much obliged!
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux