From: "J. Bruce Fields" <bfields@xxxxxxxxxx> pynfs can crash the nfs server since the new multipath code. The problem is that pynfs uses the same tcp connection for multiple v4 clients (something the spec explicitly allows). The callback client in such cases has to share the same rpc_xprt. The new rpc code, when it creates two callback clients sharing the same rpc_xprt, ends up trying to keep that rpc_xprt on the lists of two different rpc_xprt_switch's. The first symptom I see is a list corruption warning. So, I'm enforcing the requirement that there be only one backchannel rpc_xprt_switch per tcp connection by doing as we do in the rpc_xprt case: keeping a pointer to it in the svc_xprt, and using that when it's available instead of allocating a new one. That's a pretty straightforward fix (and I've verified it works), but doesn't look very elegant. If there's a better solution, I'm all ears. --b. J. Bruce Fields (3): SUNRPC: fix xprt leak on xps allocation failure nfsd4/rpc: move backchannel create logic into rpc code rpc: share one xps between all backchannels fs/nfsd/nfs4callback.c | 18 +----------------- include/linux/sunrpc/clnt.h | 2 -- include/linux/sunrpc/svc_xprt.h | 1 + include/linux/sunrpc/xprt.h | 1 + net/sunrpc/clnt.c | 31 +++++++++++++++++++++++++------ net/sunrpc/svc_xprt.c | 2 ++ net/sunrpc/xprtsock.c | 1 + 7 files changed, 31 insertions(+), 25 deletions(-) -- 2.5.5 -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
