On Wed, Mar 16, 2016 at 5:17 AM, Benjamin Coddington
<bcodding@xxxxxxxxxx> wrote:
>
> A zero-length short read without eof should be retried rather than sending
> an error to the application.
In what situation would returning a 0 length read not be a bug? If the
server intended that we back off and retry, it has the alternative of
sending a JUKEBOX/DELAY error.
> Signed-off-by: Benjamin Coddington <bcodding@xxxxxxxxxx>
> ---
> fs/nfs/read.c | 5 -----
> 1 files changed, 0 insertions(+), 5 deletions(-)
>
> diff --git a/fs/nfs/read.c b/fs/nfs/read.c
> index eb31e23..7269d42 100644
> --- a/fs/nfs/read.c
> +++ b/fs/nfs/read.c
> @@ -244,11 +244,6 @@ static void nfs_readpage_retry(struct rpc_task *task,
>
> /* This is a short read! */
> nfs_inc_stats(hdr->inode, NFSIOS_SHORTREAD);
> - /* Has the server at least made some progress? */
> - if (resp->count == 0) {
> - nfs_set_pgio_error(hdr, -EIO, argp->offset);
> - return;
> - }
>
> /* For non rpc-based layout drivers, retry-through-MDS */
> if (!task->tk_ops) {
> --
> 1.7.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
