Hi Andy & Bruce, re: Commit dc24826bfca8d788d05f625208f06d90be5560b3 (NFS avoid expired credential keys for buffered writes) Is it a valid state for ac_flags to have RPC_CRED_KEY_EXPIRE_SOON and RPC_CRED_NO_CRKEY_TIMEOUT set at the same time? >From a vmcore: ------------------------------------------------------------ crash> struct generic_cred.acred 0xffff880436644a80 acred = { uid = 0x8f08, gid = 0x870d, group_info = 0xffff88042bcecc80, principal = 0x0, ac_flags = 0x3, machine_cred = 0x0 } ------------------------------------------------------------ => ac_flags is 3. ------------------------------------------------------------ /* auth_cred ac_flags bits */ enum { RPC_CRED_NO_CRKEY_TIMEOUT = 0, /* underlying cred has no key timeout */ RPC_CRED_KEY_EXPIRE_SOON = 1, /* underlying cred key will expire soon */ RPC_CRED_NOTIFY_TIMEOUT = 2, /* nofity generic cred when underlying key will expire soon */ }; ------------------------------------------------------------ Should RPC_CRED_KEY_EXPIRE_SOON be cleared when RPC_CRED_NO_CRKEY_TIMEOUT is set? Or is that an invalid state transition? Thanks, # -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html