> On Feb 5, 2016, at 5:23 AM, Devesh Sharma <devesh.sharma@xxxxxxxxxxxx> wrote:
>
> On Wed, Feb 3, 2016 at 9:21 PM, Chuck Lever <chuck.lever@xxxxxxxxxx> wrote:
>> Add some infrastructure (shared between xprtrdma and svcrdma) for
>> constructing and parsing RPC-over-RDMA error status information.
>>
>> Signed-off-by: Chuck Lever <chuck.lever@xxxxxxxxxx>
>> ---
>> include/linux/sunrpc/rpc_rdma.h | 13 ++++++++++++-
>> 1 file changed, 12 insertions(+), 1 deletion(-)
>>
>> diff --git a/include/linux/sunrpc/rpc_rdma.h b/include/linux/sunrpc/rpc_rdma.h
>> index f33c5a4..a5a36c0 100644
>> --- a/include/linux/sunrpc/rpc_rdma.h
>> +++ b/include/linux/sunrpc/rpc_rdma.h
>> @@ -93,6 +93,12 @@ struct rpcrdma_msg {
>> __be32 rm_pempty[3]; /* 3 empty chunk lists */
>> } rm_padded;
>>
>> + struct {
>> + __be32 rm_err;
>> + __be32 rm_vers_low;
>> + __be32 rm_vers_hi;
>> + } rm_error;
>> +
>
> I don't see above members being used or filled with a value, I am
> missing the link?
The patch adds items that are used in patches that will be
submitted separately to the NFS client maintainer and the
server maintainer for 4.6. It's the same patch to avoid merge
conflicts.
The server probably only needs RPCRDMA_HDRLEN_ERR. I can
split that into a separate patch that appears in both
series, and move the rest into a client-only patch.
>> __be32 rm_chunks[0]; /* read, write and reply chunks */
>>
>> } rm_body;
>> @@ -102,12 +108,16 @@ struct rpcrdma_msg {
>> * Smallest RPC/RDMA header: rm_xid through rm_type, then rm_nochunks
>> */
>> #define RPCRDMA_HDRLEN_MIN (sizeof(__be32) * 7)
>> +#define RPCRDMA_HDRLEN_ERR (sizeof(__be32) * 5)
>>
>> enum rpcrdma_errcode {
>> ERR_VERS = 1,
>> ERR_CHUNK = 2
>> };
>>
>> +#define err_vers cpu_to_be32(ERR_VERS)
>> +#define err_chunk cpu_to_be32(ERR_CHUNK)
>> +
>> struct rpcrdma_err_vers {
>> uint32_t rdma_vers_low; /* Version range supported by peer */
>> uint32_t rdma_vers_high;
>> @@ -118,7 +128,8 @@ enum rpcrdma_proc {
>> RDMA_NOMSG = 1, /* An RPC call or reply msg - separate body */
>> RDMA_MSGP = 2, /* An RPC call or reply msg with padding */
>> RDMA_DONE = 3, /* Client signals reply completion */
>> - RDMA_ERROR = 4 /* An RPC RDMA encoding error */
>> + RDMA_ERROR = 4, /* An RPC RDMA encoding error */
>> + RDMA_LAST
>> };
>>
>> #define rdma_msg cpu_to_be32(RDMA_MSG)
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
>> the body of a message to majordomo@xxxxxxxxxxxxxxx
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Chuck Lever
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
