On Sun, Jan 31, 2016 at 5:40 AM, Kinglong Mee <kinglongmee@xxxxxxxxx> wrote: > > > On 1/25/2016 22:09, Trond Myklebust wrote: > > We need to make sure that we don't allow args->csa_sequenceid == 0. > > > > Signed-off-by: Trond Myklebust <trond.myklebust@xxxxxxxxxxxxxxx> > > --- > > fs/nfs/callback_proc.c | 43 +++++++++++++++++-------------------------- > > 1 file changed, 17 insertions(+), 26 deletions(-) > ... snip ... > > @@ -486,6 +476,13 @@ __be32 nfs4_callback_sequence(struct cb_sequenceargs *args, > > goto out_unlock; > > } > > > > + status = validate_seqid(tbl, slot, args); > > + if (status) > > + goto out_unlock; > > For NFS4ERR_RETRY_UNCACHED_REP error, nfs should initialize > cb_sequenceres information, but goto out_unlock will skip it. > Good point! I've appended a patch that fixes this. Thanks! Trond -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
