Re: [PATCH v2 3/3] NFS: Add COPY nfs operation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/20/2015 10:53 AM, Christoph Hellwig wrote:
>> +	if (res.write_res.committed != NFS_FILE_SYNC) {
>> +		status = nfs42_proc_commit(dst, pos_dst, res.write_res.count);
>> +		if (status)
>> +			return status;
>> +	}
> 
> Do we really expect data to be stabe on disk after a copy_file_range?
> Seems like the page cache variant doesn't guarantee that, and it would
> also be different from all other I/O syscalls.

It doesn't have to be, I just couldn't figure out how to mark the range as "needs commit" for the next time somebody runs fsync().

Anna

> 
> Either way we will probably need to document the assumptions in the man
> page.
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux