> On Mon, Dec 7, 2015 at 2:24 PM, Benjamin Coddington <bcodding@xxxxxxxxxx> wrote: > > On Mon, 7 Dec 2015, Christoph Hellwig wrote: > > > >> On Mon, Dec 07, 2015 at 02:13:47PM -0500, Benjamin Coddington wrote: > >> > I can fixup the comment for clarity as I just moved this chunk over. > >> > > >> > I'm not aware that flock() has ever had this check, but posix locks requires > >> > it. My understanding is that since NFS may simulate flock() with posix > >> > locking, the check is necessary for NFS. > >> > >> Ah, right. Maybe that's what should be in the comment here.. > > > > Yes, good idea. That's where someone is going to look when they investigate > > why their application breaks on NFS. > > > > Should I expect a resend? I'll do this in a v3 of this shortly. Ben -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html