On Fri, Nov 13, 2015 at 12:00 PM, Nicholas Krause <xerofoify@xxxxxxxxx> wrote: > This fixes error checking in the function > nfs4_proc_setattr to properly check and > return a error code if the call to the > function pnfs_commit_and_return_layout > has failed by returning a error code > as we cannot continue in the function > nfs4_proc_settattr after this error > code has been returned by the function, > pnfs_commit_and_return. Why not? It really is just advisory... On those architectures that require it, the pNFS server still has a responsibility to recall any outstanding layouts anyway when it receives a SETATTR call. The pnfs_commit_and_return here should mainly be an optimisation to avoid an unnecessary recall from the server, but we don't need to rely on it. Cheers Trond -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
