> If the server is revoking a delegation, then presumably it will also > set one or more of the SEQ4_STATUS_EXPIRED_SOME_STATE_REVOKED, > SEQ4_STATUS_ADMIN_STATE_REVOKED, SEQ4_STATUS_RECALLABLE_STATE_REVOKED, > which should start up a state manager thread to do the > test_stateid/free_stateid dance. > > So instead of adding the free stateid call above, why can't we just > punt the freeing of the delegation to the state manager? I inferred (perhaps incorrectly) that nfs_do_return_delegation() was a place delegations went to and didn't come back from. I managed to convince myself that since all callers of nfs_do_return_delegation() detach the delegation, the state manager wouldn't be able to perform that function without reattaching the delegation - and that doesn't look quite so safe (and/or possible) in all of those call paths? Thanks, Andy -- Andrew W. Elble aweits@xxxxxxxxxxxxxxxxxx Infrastructure Engineer, Communications Technical Lead Rochester Institute of Technology PGP: BFAD 8461 4CCF DC95 DA2C B0EB 965B 082E 863E C912 -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
