Re: [PATCH 1/1] Adding issync field to delegreturn_exit tracepoint

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Oct 13, 2015 at 1:58 PM, Andrew W Elble <aweits@xxxxxxx> wrote:
>
> Trond Myklebust <trond.myklebust@xxxxxxxxxxxxxxx> writes:
>
> >> > OK. So what are the symptoms? I'm having trouble seeing how a race can
> >> > happen, given a correctly coded server.
> >>
> >> Here's what the server sees:
> >> open (foobar) replies back with a delegation
> >> various operations including a close()
> >> some time goes by...
> >> open (foobar) replies back with the same delegation
> >
> > Why? Olga, we already had this discussion. That sort of server
> > behaviour is never going to work without races and is the root cause
> > of your problem. We simply won't ever support servers that do this.
>
> Trond,
>
>   Specifically, what would the correct behavior be here?

The server should honour the open without repeating the delegation.

The client already knows about the delegation due to the first open,
so there is no value whatsoever in repeating it. In addition, as you
see from Olga's example, it causes races with the return of that
delegation.
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux