On Wed, Oct 7, 2015 at 4:08 PM, Bruce Fields <bfields@xxxxxxxxxxxx> wrote:
> On Wed, Oct 07, 2015 at 01:54:42PM -0400, Trond Myklebust wrote:
>> If we're sending more pages via kernel_sendpage(), then set
>> MSG_SENDPAGE_NOTLAST.
>
> Given that we've survived without this a while, I assume this is a hint
> that may provide better performance in some cases (have you seen that?)
> and that it doesn't have to be 100% correct?
See the original motivation in:
commit 2f5338442425 ("tcp: allow splice() to build full TSO packets")
and the later bugfix (which actually introduces MSG_SENDPAGE_NOTLAST):
commit 35f9c09fe9c7 ("tcp: tcp_sendpages() should call tcp_push() once")
> In which case, looks fine, will queue up for 4.4....
Sure. It's a minor performance enhancement, so there is no immediate rush.
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
