> -----Original Message----- > From: Anna Schumaker [mailto:Anna.Schumaker@xxxxxxxxxx] > Sent: Monday, September 28, 2015 9:45 AM > To: Steve Wise; trond.myklebust@xxxxxxxxxxxxxxx; bfields@xxxxxxxxxxxx > Cc: linux-nfs@xxxxxxxxxxxxxxx; linux-rdma@xxxxxxxxxxxxxxx > Subject: Re: [PATCH 1/3] xprtrdma: disconnect and flush cqs before freeing buffers > > Hi Steve, > > On 09/28/2015 10:30 AM, Steve Wise wrote: > > On 9/21/2015 12:24 PM, Steve Wise wrote: > >> Otherwise a FRMR completion can cause a touch-after-free crash. > >> > >> In xprt_rdma_destroy(), call rpcrdma_buffer_destroy() only after calling > >> rpcrdma_ep_destroy(). > >> > >> In rpcrdma_ep_destroy(), disconnect the cm_id first which should flush the > >> qp, then drain the cqs, then destroy the qp, and finally destroy the cqs. > >> > >> Signed-off-by: Steve Wise <swise@xxxxxxxxxxxxxxxxxxxxx> > >> Tested-by: Chuck Lever <chuck.lever@xxxxxxxxxx> > >> --- > > > > Hey Trond, I'm hoping this can make 4.3-rc (and stable if you agree). > > This patch looks fine to me. I'll pass it on to Trond! > > I'll save patch 3/3 for the Linux 4.4 merge. > > Thanks, > Anna > Thanks. Going forward I'll make sure you are CC'd for client patches too! I wasn't sure if you are formally taking all xprtrdma patches and sending them to Trond... Steve. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
