On 9/23/2015 12:58 AM, Bart Van Assche wrote:
On 09/17/2015 02:42 AM, Sagi Grimberg wrote:
Since SRP supports both FMRs and FRWR, the new API conversion
includes splitting the sg list mapping routines in srp_map_data to
srp_map_sg_fr that works with the new memory registration API,
srp_map_sg_fmr which constructs a page vector and calls
ib_fmr_pool_map_phys, and srp_map_sg_dma which is used only
if no FRWR nor FMR are supported (which I'm not sure is a valid
use-case anymore).
The srp protocol is able to pass to the target multiple descriptors
for remote access, so it basically calls registers muleitple sg list
partials the entire sg list is mapped and registered (each time maps
a prefix of an sg list).
This sentence is hard to comprehend, and the spelling of "multiple"
should be addressed.
Another comment about this patch is that there are multiple changes in
this patch. It should be split into multiple patches, e.g. one patch
that converts srp_map_sg() into srp_map_sg_fmr() and srp_map_sg_fr() and
another patch that introduces the ib_map_mr_sg() call.
OK Bart, I'll split the patches.
Thanks,
Sagi.
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
