Re: [PATCH 0/2] nfsd: fix unhashing races in nfsv4 stateid handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



ACK to these two.  Sorry for the delay..

Ben

On Sat, 22 Aug 2015, Jeff Layton wrote:

> I hadn't heard from Andrew in a while so I'm not 100% clear on whether
> his patches had fixed the race that he had spotted in the NFSv4
> unhashing code.
>
> Still, once he had done the analysis, the problem was clear. I think
> this patchset should fix the problem in a relatively clean way. I've
> run some tests against this and it seems to not have broken anything,
> but I haven't been able to reproduce the actual race so I can't
> verify that this fixes it.
>
> Andrew, Anna, if you are able to do so could you test these patches
> and let us know whether this fixes those races?
>
> Jeff Layton (2):
>   nfsd: ensure that the ol stateid hash reference is only put once
>   nfsd: ensure that delegation stateid hash references are only put once
>
>  fs/nfsd/nfs4state.c | 76 ++++++++++++++++++++++++++++++++++-------------------
>  1 file changed, 49 insertions(+), 27 deletions(-)
>
> --
> 2.4.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux