On Wed, Sep 16, 2015 at 2:49 PM, Frank Filz <ffilzlnx@xxxxxxxxxxxxxx> wrote: > If a server has two exports from the same filesystem but with different > security flavors allowed, when the client mounts first one and then the > second, the same super block was being used. This resulted in the > security flavor for the first export being applied to access to the > second export. > > The fix is simply to check the security flavor of the nfs_server > temporarily constructed for the second mount within nfs_compare_super. > > Signed-off-by: Frank S. Filz <ffilzlnx@xxxxxxxxxxxxxx> > --- > fs/nfs/super.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/fs/nfs/super.c b/fs/nfs/super.c > index 084af10..44d60f1 100644 > --- a/fs/nfs/super.c > +++ b/fs/nfs/super.c > @@ -2455,6 +2455,9 @@ static int nfs_compare_super(struct super_block > *sb, void *data) > struct nfs_server *server = sb_mntdata->server, *old = > NFS_SB(sb); > int mntflags = sb_mntdata->mntflags; > > + if(old->client->cl_auth->au_flavor > + != server->client->cl_auth->au_flavor) > + return 0; Isn't this check already being performed in nfs_compare_mount_options()? As far as I can see, the difference is that you are checking unconditionally, whereas nfs_compare_mount_options only does so if there was a 'sec=' line specified in the mount options. Cheers Trond -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
