On Mon, 10 Aug 2015 01:28:07 -0700 Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > > I started looking at extending the nfs4_file cache to NFSv2/3, but it's > > actually rather difficult... > > > > We traditionally haven't dealt with share/deny modes in NFSv3, so we'd > > need a mechanism to bypass all of that stuff for legacy protocols. We'd > > also have to convert that cache from one that frees objects when the > > last one is put to one that keeps them around for a bit. > > > > That also means that the v2/3 opens have to keep around extra fields > > that aren't really needed, and deal with the really godawful locking of > > the NFSv4 code. > > > > I really think this approach is a better one. We can still use this > > cache from the NFSv4 code and wiring it in shouldn't be too hard. It's > > mostly a matter of plumbing in struct nfsd_file objects where that code > > is passing around struct file objects now. > > Ok. I'd still like to it wired up to NFSv4 - with my changes to make all > temporary file opens happens from nfs4_preprocess_stateid_op it should > be fairly simple. Ok, I should be able to add that in. I'll plan to do so before I send out a v3 of the patchset. -- Jeff Layton <jlayton@xxxxxxxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html