On Thu, 30 Jul 2015 08:51:35 -0700 Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > > return status; > > @@ -4628,6 +4625,10 @@ nfs4_check_file(struct svc_rqst *rqstp, struct svc_fh *fhp, struct nfs4_stid *s, > > struct file *file; > > __be32 status; > > > > + status = nfs4_check_fh(fhp, s); > > + if (status) > > + return status; > > + > > This means we check the file handle for all stateids now, not just > open and lock stateids. That seems reasonable to me but should be > mentioned in the changelog. This code is only called from nfs4_preprocess_stateid_op (which I typoed in the changelog -- maybe Bruce can fix that). Anything other than an open, lock or delegation stateid is explicitly rejected before this point. So, this just adds this check to delegation stateids (which is necessary I think). That is mentioned in the changelog though. Do you think it needs more elaboration or is that sufficient? -- Jeff Layton <jlayton@xxxxxxxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
