On Thu, Jul 30, 2015 at 08:05:32PM +0800, Kinglong Mee wrote: > On 7/30/2015 03:37, J. Bruce Fields wrote: > > On Tue, Jul 28, 2015 at 07:46:35PM +0800, Kinglong Mee wrote: > >> Signed-off-by: Kinglong Mee <kinglongmee@xxxxxxxxx> > >> --- > > > > See nfs4.1/xdrdef/README and please update that README and nfs4.x.diff > > too if necessary (and report to nfsv4@xxxxxxxx if this is still a bug in > > the minorversion 2 draft). > > Description at, > https://tools.ietf.org/html/draft-ietf-nfsv4-minorversion2-38#section-12.2.4 > > "The FATTR4_SEC_LABEL contains an array of two components with the > first component being an LFS." > > It seems both nfs server and client have wrong implement, not the rfc's bug. It looks like an rfc bug to me. Doesn't it have conflicting definitions for sec_label4? --b. > > xdrdef/nfs4.x is out of date, just update it. > > thanks, > Kinglong Mee > > > > > --b. > > > >> nfs4.1/xdrdef/nfs4.x | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/nfs4.1/xdrdef/nfs4.x b/nfs4.1/xdrdef/nfs4.x > >> index 024e0b4..cb3db7e 100644 > >> --- a/nfs4.1/xdrdef/nfs4.x > >> +++ b/nfs4.1/xdrdef/nfs4.x > >> @@ -852,7 +852,7 @@ typedef change_policy4 fattr4_change_policy; > >> typedef uint64_t fattr_space_freed; > >> typedef change_attr_type4 > >> fattr4_change_attr_type; > >> -typedef sec_label4 fattr_sec_label<>; > >> +typedef sec_label4 fattr4_sec_label; > >> > >> %/* > >> % * REQUIRED Attributes > >> -- > >> 2.4.3 > > -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
