On Jul 20, 2015, at 1:00 PM, Sagi Grimberg <sagig@xxxxxxxxxxxx> wrote: > When accounting the needed_pages, we need to look into > the page_list->max_page_list_len and not the global > context xprt->sc_frmr_pg_list_len. > > Signed-off-by: Sagi Grimberg <sagig@xxxxxxxxxxxx> > --- > net/sunrpc/xprtrdma/svc_rdma_recvfrom.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/net/sunrpc/xprtrdma/svc_rdma_recvfrom.c b/net/sunrpc/xprtrdma/svc_rdma_recvfrom.c > index 2e1348b..b19ffd3 100644 > --- a/net/sunrpc/xprtrdma/svc_rdma_recvfrom.c > +++ b/net/sunrpc/xprtrdma/svc_rdma_recvfrom.c > @@ -244,7 +244,8 @@ int rdma_read_chunk_frmr(struct svcxprt_rdma *xprt, > > ctxt->direction = DMA_FROM_DEVICE; > ctxt->frmr = frmr; > - pages_needed = min_t(int, pages_needed, xprt->sc_frmr_pg_list_len); > + pages_needed = min_t(int, pages_needed, > + frmr->page_list->max_page_list_len); This is the last user of sc_frmr_pg_list_len. If Steve thinks this is a good change, then why not remove it. The client uses ib_device_attr::max_fast_reg_page_list_len too. Should it be fixed? > read = min_t(int, pages_needed << PAGE_SHIFT, rs_length); > > frmr->kva = page_address(rqstp->rq_arg.pages[pg_no]); -- Chuck Lever -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html