I had look at other as well, but to merge them more radical changes required, like moving shared code into a separated module and renaming nfs4.0 and nfs4.1 into something else, as python does not like dots in the module name. Tigran. ----- Original Message ----- > From: "Kinglong Mee" <kinglongmee@xxxxxxxxx> > To: "tigran mkrtchyan" <tigran.mkrtchyan@xxxxxxx>, bfields@xxxxxxxxxxxx > Cc: linux-nfs@xxxxxxxxxxxxxxx, kinglongmee@xxxxxxxxx > Sent: Friday, July 17, 2015 1:54:25 AM > Subject: Re: [PATCH] pynfs: reduce code duplication > On 7/17/2015 00:40, tigran.mkrtchyan@xxxxxxx wrote: >> From: Tigran Mkrtchyan <tigran.mkrtchyan@xxxxxxx> >> >> the test suite has two methods: check and checklist to >> validate status codes of a compound operation. The both >> methods are identical, except one of them accept a single >> status code and other accepts a list. >> >> Modify 'check' to accept a list as well to reduce code >> duplication. >> >> Signed-off-by: Tigran Mkrtchyan <tigran.mkrtchyan@xxxxxxx> >> --- >> nfs4.1/server41tests/environment.py | 40 ++++++++++++------------------ >> nfs4.1/server41tests/st_current_stateid.py | 6 ++--- >> nfs4.1/server41tests/st_delegation.py | 6 ++--- >> nfs4.1/server41tests/st_destroy_session.py | 2 +- >> nfs4.1/server41tests/st_exchange_id.py | 4 +-- >> nfs4.1/server41tests/st_lookup.py | 10 ++++---- >> nfs4.1/server41tests/st_open.py | 2 +- >> nfs4.1/server41tests/st_reboot.py | 2 +- >> nfs4.1/server41tests/st_rename.py | 14 +++++------ >> nfs4.1/server41tests/st_verify.py | 4 +-- >> 10 files changed, 41 insertions(+), 49 deletions(-) >> > > Make sense. > I think clean all "checklist" is better. > > "checklist" also exist in, > nfs4.1/client41tests/environment.py > nfs4.0/servertests/environment.py > > Anyway this one is nice for nfs4.1 server. > > thanks, > Kinglong Mee -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
