On Jul 14, 2015, at 3:00 PM, Tom Talpey <tom@xxxxxxxxxx> wrote: > On 7/13/2015 12:30 PM, Chuck Lever wrote: >> RDMA_MSGP type calls insert a zero pad in the middle of the RPC >> message to align the RPC request's data payload to the server's >> alignment preferences. A server can then "page flip" the payload >> into place to avoid a data copy in certain circumstances. However: >> ... >> >> Clean up the marshaling code by removing the logic that constructs >> RDMA_MSGP type calls. This also reduces the maximum send iovec size >> from four to just two elements. >> > >> diff --git a/net/sunrpc/xprtrdma/xprt_rdma.h b/net/sunrpc/xprtrdma/xprt_rdma.h >> index 8219011..0b50103 100644 >> --- a/net/sunrpc/xprtrdma/xprt_rdma.h >> +++ b/net/sunrpc/xprtrdma/xprt_rdma.h > ...> >> +#define RPCRDMA_MAX_IOVS (4) >> + > > So, shouldn't this constant be "2"? The extra 2 iov's were used > only for constructing the pad. Yes, thanks. I folded a couple of patches together into this one, and forgot to update the constant. -- Chuck Lever -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
