On 07/14/2015 03:15 AM, Christoph Hellwig wrote: >> + /* Needs an SCSI ID with unique date not zero length */ >> + if (!dev_id->len) >> + continue; > > That explains what the code does, not why it does so. > > How about: > > /* > * Some buggy targets (e.g. VMWare) export zero length > * EVPD pages, skip them to not confuse the device id > * cache. > */ > I'm not a big fan of calling out vendors in comments. I'm thinking dropping the "buggy" and "(e.g. VMWare)" would be appropriated. steved. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
