Re: [PATCH 1/3] nfsd: Set lc_size_chg before ops->proc_layoutcommit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jul 08, 2015 at 02:44:31PM -0400, J. Bruce Fields wrote:
> On Tue, Jul 07, 2015 at 10:12:03AM +0800, Kinglong Mee wrote:
> > After proc_layoutcommit success, i_size_read(inode) always >= new_size.
> > Just set lc_size_chg before proc_layoutcommit, if proc_layoutcommit
> > failed, nfsd will skip the lc_size_chg, so it's no harm.
> 
> Looks right to me, though could probably use an ACK from Christoph.
> 
> (But looking at the spec I'm confused about how the client is supposed
> to use this information.)

I don;t think its possible to use, as there it is inherently racy.

If the test passes xfstests I'm fine with it.
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux