Re: [PATCH 1/2] pNFS: Fix a memory leak when attempted pnfs fails

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 17 Jun 2015 20:02:50 -0400
Trond Myklebust <trond.myklebust@xxxxxxxxxxxxxxx> wrote:

> pnfs_do_write() expects the call to pnfs_write_through_mds() to free the
> pgio header and to release the layout segment before exiting. The problem
> is that nfs_pgio_data_destroy() doesn't actually do this; it only frees
> the memory allocated by nfs_generic_pgio().
> 
> Ditto for pnfs_do_read()...
> 
> Fix in both cases is to add a call to hdr->release(hdr).
> 
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Trond Myklebust <trond.myklebust@xxxxxxxxxxxxxxx>
> ---
>  fs/nfs/pnfs.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/fs/nfs/pnfs.c b/fs/nfs/pnfs.c
> index 230606243be6..219ee6a3f1b3 100644
> --- a/fs/nfs/pnfs.c
> +++ b/fs/nfs/pnfs.c
> @@ -1865,6 +1865,7 @@ pnfs_write_through_mds(struct nfs_pageio_descriptor *desc,
>  		mirror->pg_recoalesce = 1;
>  	}
>  	nfs_pgio_data_destroy(hdr);
> +	hdr->release(hdr);
>  }
>  
>  static enum pnfs_try_status
> @@ -1979,6 +1980,7 @@ pnfs_read_through_mds(struct nfs_pageio_descriptor *desc,
>  		mirror->pg_recoalesce = 1;
>  	}
>  	nfs_pgio_data_destroy(hdr);
> +	hdr->release(hdr);
>  }
>  
>  /*

Reviewed-by: Jeff Layton <jeff.layton@xxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux