On Fri, 5 Jun 2015 17:01:14 +0200 Petr Mladek <pmladek@xxxxxxx> wrote: > It takes a while until the ring_buffer_benchmark module is removed > when the ring buffer hammer is running. It is because it takes > few seconds and kthread_should_terminate() is not being checked. > > This patch adds the check for kthread termination into the producer. > It uses the existing kill_test flag to finish the kthreads as > cleanly as possible. > > It disables printing the "ERROR" message when the kthread is going. > > Also it makes sure that producer does not go into the 10sec sleep > when it is being killed. This patch looks like something I may take regardless of the other patches (if it applies cleanly). As for the other patches, the ring buffer benchmark is just that, a benchmark that I use when making changes to the ring buffer. It's not something for production systems. What about just adding a depend on !LIVE_PATCHING to RING_BUFFER_BENCHMARK, or force it to shut down during patching. There's no reason to make it safe to be running when you patch the kernel. Just adds complexity to some simple code. -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
