On Thu, May 28, 2015 at 6:09 PM, Andreas Grünbacher <andreas.gruenbacher@xxxxxxxxx> wrote: > 2015-05-28 23:55 GMT+02:00 Trond Myklebust <trond.myklebust@xxxxxxxxxxxxxxx>: >>> We already do this kind of check with the existing code. What's wrong with it? >> >> Actually, you're right, we don't check for the previous word, however >> fixing that is a question of adding 2 extra checks in >> decode_getfattr_attrs(), one in decode_getfattr_statfs(), and one in >> decode_fsinfo(). >> >> It shouldn't require a rewrite of the entire nfs4xdr.c. > > I would actually prefer either verifying the reply bitmap against the > request bitmap, > or checking the bitmap first as this patch does --- the current > approach of knocking > individual bits over and checking if any "before" bits have been missed isn't > exactly what I would take as a textbook example. ...and I'd prefer that we don't keep rewriting code that works. Screw the textbooks... Trond -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
