Re: [PATCH] SUNRPC: drop stale setup_socket doc comments

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Stefan,

On 05/05/2015 10:18 AM, Stefan Hajnoczi wrote:
> xs_local_setup_socket() and xs_tcp_setup_socket() have outdated
> arguments listed in the doc comments.  Drop arguments that no longer
> exist.

Can you please fix up xs_local_data_ready(), xs_udp_data_ready(), and xs_tcp_data_ready() while you're at it?

Thanks!
Anna

> 
> Signed-off-by: Stefan Hajnoczi <stefanha@xxxxxxxxxx>
> ---
>  net/sunrpc/xprtsock.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/net/sunrpc/xprtsock.c b/net/sunrpc/xprtsock.c
> index 66891e3..a8d6c6e 100644
> --- a/net/sunrpc/xprtsock.c
> +++ b/net/sunrpc/xprtsock.c
> @@ -1886,9 +1886,7 @@ static int xs_local_finish_connecting(struct rpc_xprt *xprt,
>  
>  /**
>   * xs_local_setup_socket - create AF_LOCAL socket, connect to a local endpoint
> - * @xprt: RPC transport to connect
>   * @transport: socket transport to connect
> - * @create_sock: function to create a socket of the correct type
>   */
>  static int xs_local_setup_socket(struct sock_xprt *transport)
>  {
> @@ -2125,9 +2123,6 @@ out:
>  
>  /**
>   * xs_tcp_setup_socket - create a TCP socket and connect to a remote endpoint
> - * @xprt: RPC transport to connect
> - * @transport: socket transport to connect
> - * @create_sock: function to create a socket of the correct type
>   *
>   * Invoked by a work queue tasklet.
>   */
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux