On Fri, May 01, 2015 at 11:53:26AM +1000, NeilBrown wrote: > While writing that I began to wonder if lookup_one_len is really the right > interface to be used, even though it was introduced (in 2.3.99pre2-4) > specifically for nfsd. > The problem is that it assumes things about the filesystem. So it makes > perfect sense for various filesystems to use it on themselves, but I'm not > sure how *right* it is for nfsd (or cachefiles etc) to use it on some > *other* filesystem. > The particular issue is that it avoids the d_revalidate call. > Both vfat and reiserfs have that call ... I wonder if that could ever be a > problem. > > So I'm really leaning towards creating a variant of kern_path_mountpoint and > using a variant of that which takes a length. NAK. As in, "no way in hell". And yes, lookup_one_len() *does* revalidate - RTFS(lookup_dcache), please. What kind of consistency warranties do callers expect, BTW? You do realize that between iterate_dir() and callbacks an entry might have been removed and/or replaced? -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
