On Thu, Apr 30, 2015 at 10:24:56AM -0400, J. Bruce Fields wrote: > On Thu, Apr 30, 2015 at 11:49:23AM +0200, Christoph Hellwig wrote: > > We must only increment the sequence id if the client has seen and responded > > to a request. If we failed to deliver it to the client we must resend with > > the same sequence id. So just like the client track errors at the transport > > level differently from those returned in the XDR. > > Looks good. > > Though errors to the CB_SEQUENCE op itself don't bump the sequence id > either--maybe we need the equivalent of the logic in > fs/nfs/nfs4proc.c:nfs41_sequence_done(). For now the server logic could be a bit simpler, but that looks like a good model indeed. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html