Re: [Libtirpc-devel] [PATCH 0/9] Cleanups and fixes for musl libc

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 23 April 2015 at 18:55, Steve Dickson <SteveD@xxxxxxxxxx> wrote:
>
>
> On 12/16/2014 03:28 AM, Natanael Copa wrote:
>> Various fixes for making libtirpc build and run with musl libc.
>>
>> I have also included some cleanups that I did while at it.
>>
>> Natanael Copa (9):
>>   Replace INSTALL symlink with a copy of the file
>>   Provide getrpcbynumber and getrpcbyname if those are missing
>>   Avoid use of internal glibc sys/cdefs.h header
>>   Add configure option to disable DES authentication
>>   Fix compile error: 'IPPORT_RESERVED' undeclared
>>   Define struct rpcent on non GNU libc
>>   Include string.h for memset
>>   Fix location of various standard header includes
>>   Add a HACKING file which tells where to send patches
> All 9 patches committed...

/HAVE_GETRPCBYNYMBER/s/BYNY/BYNU/

The hunk in tirpc/rpc/rpcent.h looks like it should have been guarded
by HAVE_GETRPCBYNUMBER and HAVE_GETRPCBYNAME and not by !GLIBC.
I'd have guarded the struct with !defined bynumber  || !defined byname
but i assume conflicting declarations are hopefully rare.
rpcent.c unconditionally compiles setrpcent(), endrpcent(),
getrpcent() so these should likely be omitted if available in libc,
too.

thanks,
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux