On Mon, Mar 30, 2015 at 12:13:00PM -0400, Doug Ledford wrote: > On Fri, 2015-03-27 at 16:47 +0100, Michael Wang wrote: > > Introduce helper has_iwarp() to help us check if an IB device > > support IWARP protocol. > > This is a needless redirection. Just stick with the original > rdma_transport_is_iwarp(). Sticking with the original isn't really the point. The point here, is to document what Tom was talking about - some ports can only support one RDMA READ SGL entry, even though they support multiple RDMA WRITE SGL entries. Today the query API assumes READ/WRITE/SEND are symmetrical. has_rdma_read_sgl() is a good way to document that for now, and is a big flashing marker where something might need to be fixed in the future. This tells everyone reading the code and the API that when working with RDMA READ they need to be aware of this limitation. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html