Re: [RFC PATCH 07/11] IB/Verbs: Use management helper has_mcast() and, cap_mcast() for mcast-check

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [RFC PATCH 07/11] IB/Verbs: Use management helper has_mcast() and, cap_mcast() for mcast-check
From: Jason Gunthorpe <jgunthorpe@xxxxxxxxxxxxxxxxxxxx>
Date: Mon, 30 Mar 2015 16:33:54 -0600
Cc: "ira.weiny" <ira.weiny@xxxxxxxxx>, Roland Dreier <roland@xxxxxxxxxx>, Sean Hefty <sean.hefty@xxxxxxxxx>, Hal Rosenstock <hal.rosenstock@xxxxxxxxx>, linux-rdma@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-nfs@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, "J. Bruce Fields" <bfields@xxxxxxxxxxxx>, Trond Myklebust <trond.myklebust@xxxxxxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Or Gerlitz <ogerlitz@xxxxxxxxxxxx>, Moni Shoua <monis@xxxxxxxxxxxx>, PJ Waskiewicz <pj.waskiewicz@xxxxxxxxxxxxx>, Tatyana Nikolova <Tatyana.E.Nikolova@xxxxxxxxx>, Yan Burman <yanb@xxxxxxxxxxxx>, Jack Morgenstein <jackm@xxxxxxxxxxxxxxxxxx>, Bart Van Assche <bvanassche@xxxxxxx>, Yann Droneaud <ydroneaud@xxxxxxxxxx>, Colin Ian King <colin.king@xxxxxxxxxxxxx>, Majd Dibbiny <majd@xxxxxxxxxxxx>, Jiri Kosina <jkosina@xxxxxxx>, Matan Barak <matanb@xxxxxxxxxxxx>, Alex Estrin <alex.estrin@xxxxxxxxx>, Doug Ledford <dledford@xxxxxxxxxx>, Eric Dumazet <edumazet@xxxxxxxxxx>, Erez Shitrit <erezsh@xxxxxxxxxxxx>, Sagi Grimberg <sagig@xxxxxxxxxxxx>, Haggai Eran <haggaie@xxxxxxxxxxxx>, Shachar Raindel <raindel@xxxxxxxxxxxx>, Mike Marciniszyn <mike.marciniszyn@xxxxxxxxx>, Steve Wise <swise@xxxxxxxxxxxxxxxxxxxxx>, Tom Tucker <tom@xxxxxx>, Chuck Lever <chuck.lever@xxxxxxxxxx>
In-reply-to: <551909AC.2030304@profitbricks.com>
References: <551579CA.4030901@profitbricks.com> <55157B71.6040505@profitbricks.com> <20150327162820.GC28412@obsidianresearch.com> <20150327170508.GB27862@phlsvsds.ph.intel.com> <20150327174727.GB28901@obsidianresearch.com> <551909AC.2030304@profitbricks.com>
User-agent: Mutt/1.5.21 (2010-09-15)

On Mon, Mar 30, 2015 at 10:30:36AM +0200, Michael Wang wrote:

> Thus I also agreed check inside mcast_event_handler() is unnecessary,
> maybe we can change that logical to WARN_ON(!cap_mcast()) ?

Seems reasonable to me.

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

References:
- [RFC PATCH 00/11] IB/Verbs: IB Management Helpers
  - From: Michael Wang
- [RFC PATCH 07/11] IB/Verbs: Use management helper has_mcast() and, cap_mcast() for mcast-check
  - From: Michael Wang
- Re: [RFC PATCH 07/11] IB/Verbs: Use management helper has_mcast() and, cap_mcast() for mcast-check
  - From: Jason Gunthorpe
- Re: [RFC PATCH 07/11] IB/Verbs: Use management helper has_mcast() and, cap_mcast() for mcast-check
  - From: ira.weiny
- Re: [RFC PATCH 07/11] IB/Verbs: Use management helper has_mcast() and, cap_mcast() for mcast-check
  - From: Jason Gunthorpe
- Re: [RFC PATCH 07/11] IB/Verbs: Use management helper has_mcast() and, cap_mcast() for mcast-check
  - From: Michael Wang

Prev by Date: [PATCH] sunrpc: make debugfs file creation failure non-fatal
Next by Date: Re: [RFC PATCH 08/11] IB/Verbs: Use management helper has_iwarp() for, iwarp-check
Previous by thread: Re: [RFC PATCH 07/11] IB/Verbs: Use management helper has_mcast() and, cap_mcast() for mcast-check
Next by thread: Re: [RFC PATCH 07/11] IB/Verbs: Use management helper has_mcast() and, cap_mcast() for mcast-check
Index(es):
- Date
- Thread

[Index of Archives] [Linux Filesystem Development] [Linux USB Development] [Linux Media Development] [Video for Linux] [Linux NILFS] [Linux Audio Users] [Yosemite Info] [Linux SCSI]