On Mon, Feb 09, 2015 at 05:01:40PM +1100, NeilBrown wrote: > Hi Christoph, > I was reviewing this patch for possible backport. > As 'extent_length' is sector_t, it is unsigned (either u64 or unsigned long). > > So comparing "<= 0" has the same effect as comparing "== 0". > So the new checks are not "defensive". > > That doesn't mean they are wrong, but they could be misleading... > > There may be nothing that needs to be done here, but I thought I should let > you know. I think this is just an artefact of my earlier unsuccessful attempts at solving the problem. The real fix is the part that calculates the "extent_length" variable correctly. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
